Add TextFieldWidget::setFormatAsInteger#145
Open
YannickMG wants to merge 1 commit intoCleanroomMC:masterfrom
Open
Add TextFieldWidget::setFormatAsInteger#145YannickMG wants to merge 1 commit intoCleanroomMC:masterfrom
YannickMG wants to merge 1 commit intoCleanroomMC:masterfrom
Conversation
|
Does that automatically get the locale correct group separator? |
Contributor
Author
Yes. In 1.7.10 I had to override the locale to not get broken string separators in MUI2's local dev. For 1.7.10 we can either force the locale or go with the option of patching the font file. |
Contributor
Author
|
java.lang.StringIndexOutOfBoundsException: Range [0, 9) out of bounds for length 7 |
YannickMG
force-pushed
the
feature/number-field-widget
branch
from
38b738c to
f9dc674
Compare
YannickMG
force-pushed
the
feature/number-field-widget
branch
from
f9dc674 to
8d67eee
Compare
YannickMG
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
TextFieldWidget::setFormatAsIntegerthat formats a number as an integer with group separators. Not perfect, explicitly doesn't work with floating point numbers, but it's a start.